[PATCH] backend conditional requests 5th release

[Geoff Simmons]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 3/11/11 2:30 AM, Dmitry Panov wrote:
> 
> You're right, the patch didn't make any difference. The problem was that
> I was running an earlier version of the unpatched trunk which contained
> the ws overflow bug, so the reason memory usage was dropping from time
> to time was because one of the threads was dying.
> 
> I've installed the latest trunk and it behaved exactly like the patched
> version: after about 80k requests the virtual memory size was about 2G
> (I have 1G storage configured). I ran varnishstat -1 after that (attached).
> 
> So it looks like there is a memory leak in the current trunk.

I tried a load test, but couldn't reproduce a memory leak. With the
latest unpatched trunk using -s malloc,1G, and running httperf and an
Apache backend all on my machine, I ran a load of about 12,500 reqs/s
for over a half hour. varnishd's virtual memory size expanded to 911 MB
after 4 minutes, but no further. The stevedore stats show 415 MB
outstanding bytes after the run, which is about how much data I have in
the test site. The stevedore had allocated 7 GB and freed 6.6 GB during
the course of the run. All of that looks right to me.

Since this is about the trunk itself rather than the patch, and if
you're sure you can establish that there's a leak, maybe you should file
a bug report with the evidence.

Thanks again for your help with testing.


Best,
Geoff
- -- 
UPLEX Systemoptimierung
Schwanenwik 24
22087 Hamburg
http://uplex.de/
Mob: +49-176-63690917
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.14 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNec+yAAoJEOUwvh9pJNUR40IP/A9L5IDd7OYAocgdX096DO/b
8rwSr90kK9gwhpOaFIWf8/uUJ0kz14Aqq3xDTbEzetFNC7dvNNKzymUXmvbFyVh5
n+IMhMSBRB0evtQA9ZEOMsAOISh+/+pXifFctskO1RF8HL7tntXJIASW078AsMFJ
9Hj+3KAVl+P8dMhBGk8NXh5g6KL5c0kHw7QmLHw+C26Ixgi+ZPGwE287oKR3DvjV
qwGuQ6UyIQWKEKdm8YGjXGRqSv9C1G25SoAm5UQh/cc9WcXzI7Vw7BWTQEfwqwRI
4yH26U2TRtPkNyxX561T2amya1RVANwBtFurFnz4M3KvfEyS+2FCh6yp5mnv1WWP
Qr9E6Vt/eR4tnssy1Aob96AZS4JUKP6UMI+OySZ40Wh87wLzxgJieHMd/uyoyUQA
knRUrH2rJ27/rpTOMwYuOjbEJ6jzBdcbLpRWZeyi0Ymw2Dd6D52+CiRLu9Vm6/vI
xSCKyrwqCgAcRqlTyEt/AnJAcDBjtgS8fGXvgv4G/1IePBSw/hkHnZ2uFDPmcYoX
bZoKiMm3VmkU7i6pIwoppGIDwaLrNrFb54RBnw9lLOB/5Ag0kNRs0Gfgpnt/sfhi
Qgj/WwX3bS/H8HB4raKcvve9kDCr9y4EI8/rpAn/adwNJ7jK7brZUa/Oc3EsURSj
QcQ9/o73ZB0qYJxFMI4m
=TQkA
-----END PGP SIGNATURE-----