[Varnish] #80: Missing errorhandler causes crash

[Varnish]

#80: Missing errorhandler causes crash
--------------------+-------------------------------------------------------
 Reporter:  xingli  |        Owner:  des        
     Type:  defect  |       Status:  assigned   
 Priority:  high    |    Milestone:  Varnish 1.1
Component:  build   |      Version:  1.0        
 Severity:  major   |   Resolution:             
 Keywords:          |  
--------------------+-------------------------------------------------------
Changes (by des):

  * status:  new => assigned

Comment:

 I'm not sure a failure to unlink the VCL object should be considered an
 error at all.  Try the attached patch as a workaround (apply with {{{patch
 -l}}}):

 {{{
 === bin/varnishd/mgt_vcc.c
 ==================================================================
 --- bin/varnishd/mgt_vcc.c      (revision 34134)
 +++ bin/varnishd/mgt_vcc.c      (local)
 @@ -126,7 +126,7 @@
  {
         TAILQ_REMOVE(&vclhead, vp, list);
         printf("unlink %s\n", vp->fname);
 -       XXXAZ(unlink(vp->fname));
 +       unlink(vp->fname);
         free(vp->fname);
         free(vp->name);
         free(vp);
 }}}

 The interesting question, of course, is why the file is missing, and why
 you didn't get an error message when it failed to be created.

 We should also consider whether the initial error (Too many open files)
 can be handled more gracefully.

-- 
Ticket URL: <http://varnish.projects.linpro.no/ticket/80>
Varnish <http://varnish.projects.linpro.no/>
The Varnish HTTP Accelerator