[Varnish] #168: varnish crashes when using varnishadmin.pl (from the list) with wrong parameters

[Varnish]

#168: varnish crashes when using varnishadmin.pl (from the list) with wrong
parameters
----------------------------+-----------------------------------------------
 Reporter:  denis at zeno.org  |        Owner:  des  
     Type:  defect          |       Status:  new  
 Priority:  normal          |    Milestone:       
Component:  build           |      Version:  trunk
 Severity:  normal          |   Resolution:       
 Keywords:  coredump        |  
----------------------------+-----------------------------------------------
Changes (by anders):

 * cc: anders at fupp.net (added)

Comment:

 This problem occurs for me also. It happens exactly at the time when I
 disconnect from the connection to the management interface (using telnet):

 {{{
 Trying 127.0.0.1...
 Connected to localhost.
 Escape character is '^]'.
 vcl.load run1 /usr/local/etc/varnish.vcl
 200 0

 vcl.use run1
 200 0

 ^]
 telnet> close
 Connection closed.
 }}}

 Then, this is printed on the console:

 {{{
 Assert error in mgt_cli_callback(), mgt_cli.c line 352:
   Condition((close(cp->fdo)) == 0) not true.
   errno = 9 (Bad file descriptor)
 }}}

 Tracing the core dump, I get:

 {{{

 Program terminated with signal 6, Aborted.
 Reading symbols from /usr/local/lib/libvarnish.so.0...done.
 Loaded symbols for /usr/local/lib/libvarnish.so.0
 Reading symbols from /usr/local/lib/libvarnishcompat.so.0...done.
 Loaded symbols for /usr/local/lib/libvarnishcompat.so.0
 Reading symbols from /usr/local/lib/libvcl.so.0...done.
 Loaded symbols for /usr/local/lib/libvcl.so.0
 Reading symbols from /usr/lib/libthr.so.2...done.
 Loaded symbols for /usr/lib/libthr.so.2
 Reading symbols from /lib/libm.so.4...done.
 Loaded symbols for /lib/libm.so.4
 Reading symbols from /lib/libc.so.6...done.
 Loaded symbols for /lib/libc.so.6
 Reading symbols from /libexec/ld-elf.so.1...done.
 Loaded symbols for /libexec/ld-elf.so.1
 #0  0x0000000800c882dc in kill () from /lib/libc.so.6
 [New Thread 0x540000 (LWP 100114)]
 (gdb) bt
 #0  0x0000000800c882dc in kill () from /lib/libc.so.6
 #1  0x000000080098d02e in raise () from /usr/lib/libthr.so.2
 #2  0x0000000800c8716d in abort () from /lib/libc.so.6
 #3  0x000000080066ab99 in lbv_assert (func=0x433a00 "mgt_cli_callback",
     file=0x43318b "mgt_cli.c", line=352,
     cond=0x433aa9 "(close(cp->fdo)) == 0", err=9) at assert.c:58
 #4  0x0000000000423a1c in mgt_cli_callback (e=0x547880, what=1)
     at mgt_cli.c:352
 #5  0x0000000000425288 in ev_schedule_one (evb=0x54d100) at
 mgt_event.c:454
 #6  0x0000000000424c9a in ev_schedule (evb=0x54d100) at mgt_event.c:327
 #7  0x0000000000422567 in mgt_run (dflag=2,
     T_arg=0x7fffffffe9ad "localhost:8080") at mgt_child.c:428
 #8  0x000000000042d767 in main (argc=0, argv=0x7fffffffe748) at
 varnishd.c:559
 (gdb)
 }}}

 I also use Varnish/trunk 2096.

-- 
Ticket URL: <http://varnish.projects.linpro.no/ticket/168#comment:1>
Varnish <http://varnish.projects.linpro.no/>
The Varnish HTTP Accelerator