[Varnish] #238: regsub only replaces one occurance
Varnish
varnish-bugs at projects.linpro.no
Thu Jun 12 16:42:10 CEST 2008
#238: regsub only replaces one occurance
----------------------+-----------------------------------------------------
Reporter: galaxor | Owner: phk
Type: defect | Status: closed
Priority: high | Milestone:
Component: varnishd | Version: trunk
Severity: major | Resolution: fixed
Keywords: |
----------------------+-----------------------------------------------------
Comment (by ebik):
Replying to [comment:1 phk]:
> Your patch uses needless much memory on the workspace, a better and
smaller fix committed in #2640.
And your patch is broken. regsub("abcde","a(bcd)e","f$1g") now returns
"fbcd1g".
Now there is no way to include "&" in output.
Also you say you just add regsuball, but you modified behavior of regsub.
You document ALL changes
you made in your commit. Moreover you SHOULD split your commit to two
commits. One adding regsuball
and to one that changes the behaviour of regsub.
See ticket #249. (I found this ticket after opening that one.)
--
Ticket URL: <http://varnish.projects.linpro.no/ticket/238#comment:2>
Varnish <http://varnish.projects.linpro.no/>
The Varnish HTTP Accelerator
More information about the varnish-bugs
mailing list