[Varnish] #428: Sending badly formed parameters to the management console kills Varnish

[Varnish]

#428: Sending badly formed parameters to the management console kills Varnish
----------------------+-----------------------------------------------------
 Reporter:  petter    |        Owner:  phk  
     Type:  defect    |       Status:  new  
 Priority:  normal    |    Milestone:       
Component:  varnishd  |      Version:  trunk
 Severity:  normal    |   Resolution:       
 Keywords:            |  
----------------------+-----------------------------------------------------
Old description:

> While working on the web gui, I suddenly made Varnish die when sending
> bad input to the management port. Here is the backtrace
>
> [Switching to Thread 0xb7de36b0 (LWP 23570)]
> 0x08050b88 in VCA_tweak_acceptor (cli=0xb7c0c628, arg=0xb7c05210
> "HASH(0x8839c4c)") at cache_acceptor.c:371
> 371             for (i = 0; vca_acceptors[i]->name; i++) {
> (gdb) bt
> #0  0x08050b88 in VCA_tweak_acceptor (cli=0xb7c0c628, arg=0xb7c05210
> "HASH(0x8839c4c)") at cache_acceptor.c:371
> #1  0x0807d3c3 in tweak_acceptor (cli=0xb7c0c628, par=0x809bb3c,
> arg=0xb7c05210 "HASH(0x8839c4c)") at mgt_param.c:421
> #2  0x0807d843 in MCF_ParamSet (cli=0xb7c0c628, param=0xb7c05200
> "acceptor", val=0xb7c05210 "HASH(0x8839c4c)")
>     at mgt_param.c:860
> #3  0x0807d8fa in mcf_param_set (cli=0xb7c0c628, av=0xb7c2e140, priv=0x0)
> at mgt_param.c:884
> #4  0xb7fc8652 in cli_dispatch (cli=0xb7c0c628, clp=0x80a1d60,
> line=0xb7c79000 "param.set acceptor HASH(0x8839c4c)")
>     at cli.c:133
> #5  0x0807b706 in mgt_cli_vlu (priv=0xb7c0c610, p=0xb7c79000 "param.set
> acceptor HASH(0x8839c4c)") at mgt_cli.c:252
> #6  0xb7fcbda0 in LineUpProcess (l=0xb7c071e0) at vlu.c:97
> #7  0xb7fcbf9b in VLU_Fd (fd=9, l=0xb7c071e0) at vlu.c:122
> #8  0x0807bce7 in mgt_cli_callback (e=0xb7c76290, what=1) at
> mgt_cli.c:347
> #9  0xb7fcba9f in vev_schedule_one (evb=0xb7c0c5b0) at vev.c:500
> #10 0xb7fcb2b6 in vev_schedule (evb=0xb7c0c5b0) at vev.c:365
> #11 0x0807a0e3 in mgt_run (dflag=0, T_arg=0xbfce8745 ":9002") at
> mgt_child.c:560
> #12 0x080870d2 in main (argc=0, argv=0xbfce6a84) at varnishd.c:639

New description:

 While working on the web gui, I suddenly made Varnish die when sending bad
 input to the management port. Here is the backtrace
 {{{
 [Switching to Thread 0xb7de36b0 (LWP 23570)]
 0x08050b88 in VCA_tweak_acceptor (cli=0xb7c0c628, arg=0xb7c05210
 "HASH(0x8839c4c)") at cache_acceptor.c:371
 371             for (i = 0; vca_acceptors[i]->name; i++) {
 (gdb) bt
 #0  0x08050b88 in VCA_tweak_acceptor (cli=0xb7c0c628, arg=0xb7c05210
 "HASH(0x8839c4c)") at cache_acceptor.c:371
 #1  0x0807d3c3 in tweak_acceptor (cli=0xb7c0c628, par=0x809bb3c,
 arg=0xb7c05210 "HASH(0x8839c4c)") at mgt_param.c:421
 #2  0x0807d843 in MCF_ParamSet (cli=0xb7c0c628, param=0xb7c05200
 "acceptor", val=0xb7c05210 "HASH(0x8839c4c)")
     at mgt_param.c:860
 #3  0x0807d8fa in mcf_param_set (cli=0xb7c0c628, av=0xb7c2e140, priv=0x0)
 at mgt_param.c:884
 #4  0xb7fc8652 in cli_dispatch (cli=0xb7c0c628, clp=0x80a1d60,
 line=0xb7c79000 "param.set acceptor HASH(0x8839c4c)")
     at cli.c:133
 #5  0x0807b706 in mgt_cli_vlu (priv=0xb7c0c610, p=0xb7c79000 "param.set
 acceptor HASH(0x8839c4c)") at mgt_cli.c:252
 #6  0xb7fcbda0 in LineUpProcess (l=0xb7c071e0) at vlu.c:97
 #7  0xb7fcbf9b in VLU_Fd (fd=9, l=0xb7c071e0) at vlu.c:122
 #8  0x0807bce7 in mgt_cli_callback (e=0xb7c76290, what=1) at mgt_cli.c:347
 #9  0xb7fcba9f in vev_schedule_one (evb=0xb7c0c5b0) at vev.c:500
 #10 0xb7fcb2b6 in vev_schedule (evb=0xb7c0c5b0) at vev.c:365
 #11 0x0807a0e3 in mgt_run (dflag=0, T_arg=0xbfce8745 ":9002") at
 mgt_child.c:560
 #12 0x080870d2 in main (argc=0, argv=0xbfce6a84) at varnishd.c:639
 }}}

-- 
Ticket URL: <http://varnish.projects.linpro.no/ticket/428#comment:2>
Varnish <http://varnish.projects.linpro.no/>
The Varnish HTTP Accelerator