[Varnish] #560: Missing errorhandling code in HSH_Prepare()

[Varnish]

#560: Missing errorhandling code in HSH_Prepare()
----------------------+-----------------------------------------------------
 Reporter:  orjan     |       Owner:  phk             
     Type:  defect    |      Status:  new             
 Priority:  normal    |   Milestone:                  
Component:  varnishd  |     Version:  2.0             
 Severity:  major     |    Keywords:  hash vary cookie
----------------------+-----------------------------------------------------
 I'm running varnish-2.0.4-1.el5 on RHEL 5.4 x86_64

 I got quite a lot of these in my logs this morning, and the service was
 down for a minute or so:


 {{{
 Panic message: Missing errorhandling code in HSH_Prepare(), cache_hash.c
 line 188:#012  Condition((p) != 0) not true.
 thread = (cache-worker)sp = 0x2aad2e189008 {#012  fd = 13, id = 13, xid =
 751392630,#012  client = 172.23.22.190:44006,#012
 step = STP_LOOKUP,#012  handling = lookup,#012  ws = 0x2aad2e189078 {
 overflow#012    id = "sess",#012
 {s,f,r,e} = {0x2aad2e189808,,+16368,(nil),+16384},#012  },#012    worker =
 0x43df2bd0 {#012    },#012    vcl = {#012
 srcname = {#012        "input",#012        "Default",#012      },#012
 },#012},#012

 }}}

 Full vcl-config can be found here: https://paste.redpill-linpro.com/160
 (requires login)

 Most interesting is perhaps that i set the "Vary: Cookie" header in an
 attempt to emulate the squids that i'm currently replacing. This seems to
 annoy HSH_Prepare()

 This other one came at roughly the same time, but might not be related:


 {{{
 Panic message: Assert error in VRT_r_req_xid(), cache_vrt.c line 544:#012
 Condition((p = WS_Alloc(sp->http->ws, size)) != 0) not true.
   thread = (cache-worker)sp = 0x2aad2d54c008 {#012  fd = 10, id = 10, xid
 = 1926762735,#012  client = 172.23.22.190:44998,#012
 step = STP_ERROR,#012  handling = error,#012  err_code = 503, err_reason =
 (null),#012  ws = 0x2aad2d54c078 { overflow#012
 id = "sess",#012    {s,f,r,e} = {0x2aad2d54c808,,+16378,(nil),+16384},#012
 },#012    worker = 0x4a074bd0 {#012    },#012
 vcl = {#012      srcname = {#012        "input",#012        "Default",#012
 },#012    },#012  obj = 0x2aaaab000000 {#012
 refcnt = 1, xid = 1926762735,#012    ws = 0x2aaaab000028 { #012      id =
 "obj",#012      {s,f,r,e} = {0x2aaaab000358,,+140,(nil),+7336},#012
 },#012
 http = {#012      ws = 0x2aaaab000028 { #012        id = "obj",#012
 {s,f,r,e} = {0x2aaaab000358,,+140,(nil),+7336},#012      },#012
 hd = {#012        "Date: Fri, 25 Sep 2009 08:01:59 GMT",#012
 "Server: Varnish",#012        "Retry-After: 0",#012
 "Content-Type: text/html; charset=utf-8",#012      },#012    },#012    len
 = 0,#012    store = {#012    },#012  },#012},#012
 }}}

-- 
Ticket URL: <http://varnish.projects.linpro.no/ticket/560>
Varnish <http://varnish.projects.linpro.no/>
The Varnish HTTP Accelerator