[Varnish] #765: [PATCH] varnishtop segfault i686

[Varnish]

#765: [PATCH] varnishtop segfault i686
------------------------+---------------------------------------------------
 Reporter:  kwy         |       Owner:  phk                
     Type:  defect      |      Status:  new                
 Priority:  normal      |   Milestone:  Varnish 2.1 release
Component:  varnishtop  |     Version:  2.1.3              
 Severity:  normal      |    Keywords:                     
------------------------+---------------------------------------------------
 Segfault backtrace:

 Starting program: /root/varnish-2.1.3/bin/varnishtop/.libs/varnishtop
 [Thread debugging using libthread_db enabled]
 [New Thread 0xb75206b0 (LWP 22330)]
 [New Thread 0xb250eb90 (LWP 22333)]

 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 0xb250eb90 (LWP 22333)]
 0xb760fd55 in memcpy () from /lib/i686/cmov/libc.so.6
 #0  0xb760fd55 in memcpy () from /lib/i686/cmov/libc.so.6
 No symbol table info available.
 #1  0x08049181 in accumulate (p=0xb39d2f00 "\020") at varnishtop.c:122
         tp = (struct top *) 0x9cc3520
         tp2 = (struct top *) 0x1
         q = (const unsigned char *) 0xb39d2f0a ""
         u = 224
         l = 3
         i = 3
         __func__ = "accumulate"
 #2  0x0804953a in accumulate_thread (arg=0x9cad008) at varnishtop.c:197
         p = (unsigned char *) 0xb39d2f00 "\020"
         i = 1
         vd = (struct VSL_data *) 0x9cad008
 #3  0xb76f94c0 in start_thread () from /lib/i686/cmov/libpthread.so.0
 No symbol table info available.
 #4  0xb767884e in clone () from /lib/i686/cmov/libc.so.6
 No symbol table info available.
 #0  0xb760fd55 in memcpy () from /lib/i686/cmov/libc.so.6
 #1  0x08049181 in accumulate (p=0xb39d2f00 "\020") at varnishtop.c:122
 #2  0x0804953a in accumulate_thread (arg=0x9cad008) at varnishtop.c:197
 #3  0xb76f94c0 in start_thread () from /lib/i686/cmov/libpthread.so.0
 #4  0xb767884e in clone () from /lib/i686/cmov/libc.so.6
 quit


 patchfix diff:
 --- varnishtop.c.old    2010-08-27 16:32:29.000000000 +0200
 +++ varnishtop.c        2010-08-27 16:32:33.000000000 +0200
 @@ -55,7 +55,7 @@
  #include "varnishapi.h"

  struct top {
 -       unsigned char           rec[4];
 +       unsigned char           rec[6];
         unsigned char           *rec_data;
         unsigned                clen;
         unsigned                hash;

-- 
Ticket URL: <http://varnish-cache.org/ticket/765>
Varnish <http://varnish-cache.org/>
The Varnish HTTP Accelerator