[Varnish] #581: struct acct stats counted improperly in 2.0.5

Varnish varnish-bugs at projects.linpro.no
Mon Jan 4 15:59:29 CET 2010


#581: struct acct stats counted improperly in 2.0.5
------------------------+---------------------------------------------------
 Reporter:  tgr         |        Owner:  tfheen
     Type:  defect      |       Status:  closed
 Priority:  normal      |    Milestone:        
Component:  varnishd    |      Version:  2.0   
 Severity:  normal      |   Resolution:  fixed 
 Keywords:  acct stats  |  
------------------------+---------------------------------------------------
Changes (by tfheen):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 This was fixed in r4398.

 {{{
 commit 3cb38c0343428f0352a1e519cc8e733a69d054b2
 Author: tfheen <tfheen at d4fa192b-c00b-0410-8231-f00ffab90ce4>
 Date:   Wed Dec 16 08:50:49 2009 +0000

     Merge small part of r4215: Charge sessions when herding

     In 2.0.5 we default to lingering for a bit which can cause sessions to
     not be charged for a long time.  This fixes it.



     git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/branches/2.0@4398
 d4fa192b-c00b-0410-8231-f00ffab90ce4

 diff --git a/varnish-cache/bin/varnishd/cache_center.c b/varnish-
 cache/bin/varnishd/cache_center.c
 index ef54b32..87e1566 100644
 --- a/varnish-cache/bin/varnishd/cache_center.c
 +++ b/varnish-cache/bin/varnishd/cache_center.c
 @@ -105,6 +105,7 @@ cnt_wait(struct sess *sp)
                         if (i == 0) {
                                 WSL(sp->wrk, SLT_Debug, sp->fd,
 "herding");
                                 VSL_stats->sess_herd++;
 +                               SES_Charge(sp);
                                 sp->wrk = NULL;
                                 vca_return_session(sp);
                                 return (1);

 }}}

-- 
Ticket URL: <http://varnish.projects.linpro.no/ticket/581#comment:5>
Varnish <http://varnish.projects.linpro.no/>
The Varnish HTTP Accelerator


More information about the varnish-bugs mailing list