BUG found

[Poul-Henning Kamp]

In message <69e4c7971002170515q401a8e23g2228dfabfa1bb88d at mail.gmail.com>, Satos
hi Abe writes:
>Dear varnish developpers.
>
>I found the bug.

Apologies for the delay in getting back to you, you email got buried
in my inbox.

This was fixed in r4529.

Poul-Henning


>I use ESI function  by HTTP 1.0. I send http-request with "Connection:
>keep-alive" header.
>When the content length is not understood, it is necessary to close
>the connection in HTTP/1.0 or less.
>
>However, varnish returned "Connection: keep-alive", and keep the connection.
>Then, HTTP-Client is waited for until the time-out because the end of
>contents is not understood.
>
>I hope to add the following codes to correct this bug.
>
>cache_response.c  line 144
>
>                // Http 1.0 should be connection close. by a3104
>                if (sp->http->protover <= 1.0){
>                        sp->doclose = "Connection: close";
>                }
>
>
>------
>        /* Only HTTP 1.1 can do Chunked encoding */
>        if (!sp->disable_esi && !VTAILQ_EMPTY(&sp->obj->esibits)) {
>                http_Unset(sp->http, H_Content_Length);
>                if(sp->http->protover >= 1.1)
>                        http_PrintfHeader(sp->wrk, sp->fd, sp->http,
>"Transfer-Encoding: chunked");
>
                // Http 1.0 should be disconnect http session. by a3104
>                if (sp->http->protover == 1.0){
>                        sp->doclose = "Connection: close";
>                }
>        }

>------------
>Thanks and regards.
>_______________________________________________
>varnish-bugs mailing list
>varnish-bugs at projects.linpro.no
>http://projects.linpro.no/mailman/listinfo/varnish-bugs
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.