[Varnish] #972: varnishd asserts when trying to do 304 while streaming

[Varnish]

#972: varnishd asserts when trying to do 304 while streaming
--------------------+-------------------------------------------------------
 Reporter:  martin  |       Owner:  martin
     Type:  defect  |      Status:  new   
 Priority:  normal  |   Milestone:        
Component:  build   |     Version:  3.0.0 
 Severity:  normal  |    Keywords:        
--------------------+-------------------------------------------------------
Description changed by martin:

Old description:

> When the criteria for doing a 304 is met and do_stream is set, varnishd
> asserts.
>
> Problem spotted by DocWilco.
>
> ***  v1    0.6 debug| Child (11528) Panic message: Assert error in
> RES_StreamStart(), cache_response.c line 414:\n
> ***  v1    0.6 debug|   Condition((sp->wantbody) != 0) not true.\n
> ***  v1    0.6 debug| thread = (cache-worker)\n
> ***  v1    0.6 debug| ident =
> Linux,2.6.38-10-generic,x86_64,-sfile,-smalloc,-hcritbit,epoll\n
> ***  v1    0.6 debug| Backtrace:\n
> ***  v1    0.6 debug|   0x42c935: pan_ic+b5\n
> ***  v1    0.6 debug|   0x430095: RES_StreamStart+145\n
> ***  v1    0.6 debug|   0x415186: cnt_streambody+c6\n
> ***  v1    0.6 debug|   0x41684d: CNT_Session+141d\n
> ***  v1    0.6 debug|   0x42dbb8: wrk_do_cnt_sess+b8\n
> ***  v1    0.6 debug|   0x42e5e9: wrk_thread_real+409\n
> ***  v1    0.6 debug|   0x7f34b65c6d8c: _end+7f34b5f4eab4\n
> ***  v1    0.6 debug|   0x7f34b631204d: _end+7f34b5c99d75\n
> ***  v1    0.6 debug| sp = 0x7f34b0c14008 {\n
> ***  v1    0.6 debug|   f...

New description:

 When the criteria for doing a 304 is met and do_stream is set, varnishd
 asserts.

 Problem spotted by DocWilco.

 {{{
 ***  v1    0.6 debug| Child (11528) Panic message: Assert error in
 RES_StreamStart(), cache_response.c line 414:\n
 ***  v1    0.6 debug|   Condition((sp->wantbody) != 0) not true.\n
 ***  v1    0.6 debug| thread = (cache-worker)\n
 ***  v1    0.6 debug| ident =
 Linux,2.6.38-10-generic,x86_64,-sfile,-smalloc,-hcritbit,epoll\n
 ***  v1    0.6 debug| Backtrace:\n
 ***  v1    0.6 debug|   0x42c935: pan_ic+b5\n
 ***  v1    0.6 debug|   0x430095: RES_StreamStart+145\n
 ***  v1    0.6 debug|   0x415186: cnt_streambody+c6\n
 ***  v1    0.6 debug|   0x41684d: CNT_Session+141d\n
 ***  v1    0.6 debug|   0x42dbb8: wrk_do_cnt_sess+b8\n
 ***  v1    0.6 debug|   0x42e5e9: wrk_thread_real+409\n
 ***  v1    0.6 debug|   0x7f34b65c6d8c: _end+7f34b5f4eab4\n
 ***  v1    0.6 debug|   0x7f34b631204d: _end+7f34b5c99d75\n
 ***  v1    0.6 debug| sp = 0x7f34b0c14008 {\n
 ***  v1    0.6 debug|   f...
 }}}

--

-- 
Ticket URL: <http://varnish-cache.org/trac/ticket/972#comment:1>
Varnish <http://varnish-cache.org/>
The Varnish HTTP Accelerator