[Varnish] #910: handling esi:include target with pipe crashes varnish

Varnish varnish-bugs at varnish-cache.org
Mon May 9 16:54:03 CEST 2011


#910: handling esi:include target with pipe crashes varnish
-----------------------+----------------------------------------------------
  Reporter:  askalski  |        Type:  defect  
    Status:  closed    |    Priority:  normal  
 Milestone:            |   Component:  varnishd
   Version:  trunk     |    Severity:  normal  
Resolution:  wontfix   |    Keywords:          
-----------------------+----------------------------------------------------

Comment(by askalski):

 Two comments about the wontfix resolution, before I let this ticket go (I
 don't use pipe, so the crash doesn't actually affect me)...

 1. Shouldn't this at least be a documentation fix?

 2. I can dream up scenarios where the assert would be undesirable.  The
 varnish administrator may be a different person/team/organization from the
 people publishing HTML pages.  Are assertions an appropriate way to
 perform input validation?  I would think that if it's at all possible, an
 attempted "pipe" on an esi-include should skip over esi tag and log an
 error to shmlog.  That way, an admin who cared about that type of error
 could monitor and alert on the shmlog.

-- 
Ticket URL: <http://www.varnish-cache.org/trac/ticket/910#comment:2>
Varnish <http://varnish-cache.org/>
The Varnish HTTP Accelerator




More information about the varnish-bugs mailing list