[Varnish] #1017: ESI includes not getting parsed due to faulty comments

Varnish varnish-bugs at varnish-cache.org
Mon Apr 23 16:04:46 CEST 2012

#1017: ESI includes not getting parsed due to faulty comments
  Reporter:  ddunlop     |        Type:  defect      
    Status:  closed      |    Priority:  normal      
 Milestone:              |   Component:  varnishd    
   Version:  3.0.1       |    Severity:  normal      
Resolution:  worksforme  |    Keywords:  esi, parsing
Changes (by phk):

  * status:  new => closed
  * resolution:  => worksforme


 Sorry about not getting to this earlier.

 I think Varnish behaves sensibly in this case, it sees the beginning of a
 comment, and ignores everything up to the end of a comment.

 The definition of a comment in XML is
 Comment ::= '<!--' ((Char - '-') | ('-' (Char - '-')))* '-->'
 (See: http://www.w3.org/TR/REC-xml/#sec-comments)

 Which specifically does not allow for a minus right before the "end of
 comment" sequence, (which is what causes the trouble in the example you
 show) so the comment never ends and Varnish does not process ESI inside

Ticket URL: <https://www.varnish-cache.org/trac/ticket/1017#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator

More information about the varnish-bugs mailing list