[Varnish] #1115: varnishncsa spuriously logs incorrect request URLs

[Varnish]

#1115: varnishncsa spuriously logs incorrect request URLs
-------------------------+---------------------
 Reporter:  lampe        |       Owner:  tfheen
     Type:  defect       |      Status:  new
 Priority:  normal       |   Milestone:
Component:  varnishncsa  |     Version:  3.0.2
 Severity:  minor        |  Resolution:
 Keywords:               |
-------------------------+---------------------

Comment (by lampe):

 The culprit in this case is:

 {{{
 qs = index(ptr, '?');
 if (qs) {
     lp->df_U = trimline(ptr, qs);
 }}}

 ptr is not null-terminated and filled with previous contents. qs could
 match beyond end.

 The works-for-me solution is to use memchr(ptr, '?', len) instead of
 index() or strchr()

-- 
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1115#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator