[Varnish] #416: Segfault

[Varnish]

#416: Segfault
--------------------+-----------------------
 Reporter:  sky     |       Owner:  sky
     Type:  defect  |      Status:  reopened
 Priority:  normal  |   Milestone:
Component:  build   |     Version:  2.0
 Severity:  normal  |  Resolution:
 Keywords:          |
--------------------+-----------------------
Changes (by phk):

 * status:  closed => reopened
 * resolution:  fixed =>


Old description:

> {{{
> #0  0x00007ff58d931095 in raise () from /lib/libc.so.6
> #1  0x00007ff58d932af0 in abort () from /lib/libc.so.6
> #2  0x000000000042111a in pan_ic (func=0x450cae "Tcheck", file=0x450cc0
> "cache.h", line=674, cond=0x450cb5 "(t.b) != 0", err=0,
>     xxx=0) at cache_panic.c:325
> #3  0x000000000041c929 in Tcheck (t={b = 0x0, e = 0x0}) at cache.h:674
> #4  0x000000000041c9e0 in http_findhdr (hp=0x7ff2e3c5e0b8, l=13,
> hdr=0x665f11 "Cache-Control:") at cache_http.c:194
> #5  0x000000000041cb4f in http_GetHdr (hp=0x7ff2e3c5e0b8, hdr=0x665f11
> "Cache-Control:", ptr=0x7fd25d1dd9d8) at cache_http.c:216
> #6  0x000000000041cc34 in http_GetHdrField (hp=0x7ff2e3c5e0b8,
> hdr=0x665f10 "\016Cache-Control:", field=0x45a722 "s-maxage",
>     ptr=0x7fd25d1dda98) at cache_http.c:244
> #7  0x0000000000439714 in RFC2616_Ttl (sp=0x7fd146553008,
> hp=0x7ff2e3c5e0b8, obj=0x7ff2e3c5e000) at rfc2616.c:95
> #8  0x0000000000439ba6 in RFC2616_cache_policy (sp=0x7fd146553008,
> hp=0x7ff2e3c5e0b8) at rfc2616.c:199
> #9  0x00000000004122cf in cnt_fetch (sp=0x7fd146553008) at
> cache_center.c:406
> #10 0x00000000004142d3 in CNT_Session (sp=0x7fd146553008) at steps.h:41
> #11 0x0000000000422c89 in wrk_do_cnt_sess (w=0x7fd25d1e5c30,
> priv=0x7fd146553008) at cache_pool.c:362
> #12 0x0000000000422320 in wrk_thread (priv=0x7ff58d543320) at
> cache_pool.c:276
> #13 0x00007ff58e1013f7 in start_thread () from /lib/libpthread.so.0
> #14 0x00007ff58d9d6b3d in clone () from /lib/libc.so.6
> #15 0x0000000000000000 in ?? ()
> }}}

New description:

 {{{
 #0  0x00007ff58d931095 in raise () from /lib/libc.so.6
 #1  0x00007ff58d932af0 in abort () from /lib/libc.so.6
 #2  0x000000000042111a in pan_ic (func=0x450cae "Tcheck", file=0x450cc0
 "cache.h", line=674, cond=0x450cb5 "(t.b) != 0", err=0,
     xxx=0) at cache_panic.c:325
 #3  0x000000000041c929 in Tcheck (t={b = 0x0, e = 0x0}) at cache.h:674
 #4  0x000000000041c9e0 in http_findhdr (hp=0x7ff2e3c5e0b8, l=13,
 hdr=0x665f11 "Cache-Control:") at cache_http.c:194
 #5  0x000000000041cb4f in http_GetHdr (hp=0x7ff2e3c5e0b8, hdr=0x665f11
 "Cache-Control:", ptr=0x7fd25d1dd9d8) at cache_http.c:216
 #6  0x000000000041cc34 in http_GetHdrField (hp=0x7ff2e3c5e0b8,
 hdr=0x665f10 "\016Cache-Control:", field=0x45a722 "s-maxage",
     ptr=0x7fd25d1dda98) at cache_http.c:244
 #7  0x0000000000439714 in RFC2616_Ttl (sp=0x7fd146553008,
 hp=0x7ff2e3c5e0b8, obj=0x7ff2e3c5e000) at rfc2616.c:95
 #8  0x0000000000439ba6 in RFC2616_cache_policy (sp=0x7fd146553008,
 hp=0x7ff2e3c5e0b8) at rfc2616.c:199
 #9  0x00000000004122cf in cnt_fetch (sp=0x7fd146553008) at
 cache_center.c:406
 #10 0x00000000004142d3 in CNT_Session (sp=0x7fd146553008) at steps.h:41
 #11 0x0000000000422c89 in wrk_do_cnt_sess (w=0x7fd25d1e5c30,
 priv=0x7fd146553008) at cache_pool.c:362
 #12 0x0000000000422320 in wrk_thread (priv=0x7ff58d543320) at
 cache_pool.c:276
 #13 0x00007ff58e1013f7 in start_thread () from /lib/libpthread.so.0
 #14 0x00007ff58d9d6b3d in clone () from /lib/libc.so.6
 #15 0x0000000000000000 in ?? ()
 }}}

--

Comment:

 Reopening, see vtc case, we don't properly handle beresp with too many
 headers.  (also, trying to get beresp.body with no vbc)

-- 
Ticket URL: <https://www.varnish-cache.org/trac/ticket/416#comment:6>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator