[Varnish] #1484: Extra provides in 4.0.0 RPM packages

[Varnish]

#1484: Extra provides in 4.0.0 RPM packages
-----------------------+----------------------
 Reporter:  lkarsten   |      Owner:  lkarsten
     Type:  defect     |     Status:  new
 Priority:  normal     |  Milestone:
Component:  packaging  |    Version:  4.0.0
 Severity:  normal     |   Keywords:
-----------------------+----------------------
 [originally posted to varnish-dev@ by Ingvar Hagelund]

 I should have reported this by trac, but it is down at the moment.

 There are some serious build errors in the rpm packages of varnish-4.0.0
 from the varnish-cache.org repository.

 Consider the following; varnish should _not_ provide things like
 libc.so.6, libncurses or /bin/bash !!! This breaks the rpm database. It
 should be fixed as soon as possible.

 {{{
 $ rpm -qp --provides varnish-4.0.0-1.el6.x86_64.rpm
 /bin/bash
 /bin/sh
 libc.so.6()(64bit)
 libc.so.6(GLIBC_2.2.5)(64bit)
 libc.so.6(GLIBC_2.3.2)(64bit)
 libc.so.6(GLIBC_2.3)(64bit)
 libdl.so.2()(64bit)
 libdl.so.2(GLIBC_2.2.5)(64bit)
 libedit.so.0()(64bit)
 libjemalloc.so.1()(64bit)
 libm.so.6()(64bit)
 libm.so.6(GLIBC_2.2.5)(64bit)
 libncurses.so.5()(64bit)
 libncursesw.so.5()(64bit)
 libnsl.so.1()(64bit)
 libpcre.so.0()(64bit)
 libpthread.so.0()(64bit)
 libpthread.so.0(GLIBC_2.2.5)(64bit)
 libpthread.so.0(GLIBC_2.3.2)(64bit)
 librt.so.1()(64bit)
 librt.so.1(GLIBC_2.2.5)(64bit)
 libtinfo.so.5()(64bit)
 libvarnishapi.so.1()(64bit)
 libvarnishcompat.so()(64bit)
 libvarnish.so()(64bit)
 libvcc.so()(64bit)
 libvgz.so()(64bit)
 varnishabi-4.0.0-26c2dc6
 varnish = 4.0.0-1.el6
 varnish(x86-64) = 4.0.0-1.el6
 }}}

 This is caused by a small typo/bug in redhat/find-provides. The script
 calls the system's find-requires. It should call find-provides. Also the
 correct path is /usr/lib/rpm/redhat/find-provides, from the redhat-rpm-
 config package on redhat and derivates, though the path in the script may
 be available by historical reasons, or perhaps for compatibility with
 other rpm based distributions.

 Fixing the script will fix the bug. This would also make the explicit
 provides of LIBVARNISHAPI for various versions unnecessary, so they should
 be removed as well. I proposed adding these as a workaround in an earlier
 trac bug, since I didn't catch the script bug in tp2+. That workaround was
 dropped in verbatim, though it was hard coded for 64bit, which is yet
 another bug, though only visible on 32bit systems.

 Since all this happens in the rpm package only, the easiest way out is
 fixing the script by adding a patch to the rpm, fixing those other bits,
 bump the rpm Release tag, and then you only need to roll new rpm packages.
 A complete release should no be necessary.

-- 
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1484>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator