[Varnish] #1773: Incomplete code in VDP_ESI()

[Varnish]

#1773: Incomplete code in VDP_ESI()
-----------------------------+-------------------------
 Reporter:  llavaud          |       Owner:
     Type:  defect           |      Status:  closed
 Priority:  normal           |   Milestone:
Component:  varnishd         |     Version:  4.1.0-TP1
 Severity:  major            |  Resolution:  worksforme
 Keywords:  Incomplete code  |
-----------------------------+-------------------------
Changes (by phk):

 * status:  new => closed
 * resolution:   => worksforme


Comment:

 I have no idea what is going on here, and there is not enough details to
 find out.

 Basically what happened was that the ESI-cmd-string was illegal ...
 somehow.

 Obviously the most likely cause is some obscure programming error in
 Varnish.

 I don't think it is the code actually creating/parsing the ESI-cmd-string,
 but writing through an invalid pointer might do it.

 I have improved the error-reporting a little bit, so that varnishlog
 contains clues if this happens again, but I am closing this ticket now
 (sorry about the "worksforme" it is the least bogus reason I have to
 choose from), because there is nothing more I can do.

 If this happens again, please reopen this ticket, and try to include any
 "Error" records in varnishlog output.

 Considering how many bytes Varnish' ESI code pushes every second all over
 the world, and that this is the first such bug-report for the code, the
 probability of this being a random non-ECC-detected RAM error on your
 machine isn't entirely unreasonable, and the ESI code is one of the few
 places where such an error has a high likelyhood of being being detected,
 so keep an eye out for that machine in general.

-- 
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1773#comment:1>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator