[Varnish] #1650: xff handling discards multiple headers

Varnish varnish-bugs at varnish-cache.org
Wed Jan 14 16:59:15 CET 2015


#1650: xff handling discards multiple headers
--------------------------+---------------------------------------------
 Reporter:  KlavsKlavsen  |       Owner:  Federico G. Schwindt <fgsch@…>
     Type:  defect        |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  build         |     Version:  4.0.2
 Severity:  normal        |  Resolution:  fixed
 Keywords:                |
--------------------------+---------------------------------------------

Comment (by KlavsKlavsen):

 I tried building v4.0.2 with this patch added - but 1 test fails.. output
 from rpmbuild -bb varnish.spec (modd'ed to apply the patch)..

 I reworked the patch to fit v4.0.2:
 --- a/bin/varnishd/cache/cache_req_fsm.c        2014-10-08
 09:48:41.000000000 +0200
 +++ b/bin/varnishd/cache/cache_req_fsm.c        2015-01-14
 16:51:03.984994158 +0100
 @@ -723,6 +723,7 @@
                  * This really should be done earlier, but we want to
 capture
                  * it in the VSL log.
                  */
 +                http_CollectHdr(req->http, H_X_Forwarded_For);
                 if (http_GetHdr(req->http, H_X_Forwarded_For, &xff)) {
                         http_Unset(req->http, H_X_Forwarded_For);
                         http_PrintfHeader(req->http, "X-Forwarded-For: %s,
 %s",

-- 
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1650#comment:13>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator



More information about the varnish-bugs mailing list