[Varnish] #1800: PRIV_TASK in a vmod object method leads to code that cannot be compiled/linked
Varnish
varnish-bugs at varnish-cache.org
Mon Oct 26 11:02:15 CET 2015
#1800: PRIV_TASK in a vmod object method leads to code that cannot be
compiled/linked
--------------------+---------------------
Reporter: geoff | Owner: aondio
Type: defect | Status: new
Priority: normal | Milestone: Later
Component: vmod | Version: 4.1.0
Severity: normal | Resolution:
Keywords: |
--------------------+---------------------
Comment (by geoff):
aondio, thanks, I can confirm that make check succeeds for Varnish with
the patch, and also that my use of PRIV_TASK in a vmod object method
succeeds.
But I think that a few things are still missing, as we talked about in
email.
Since the patch also addresses the use of PRIV_VCL and PRIV_TOP in
methods, shouldn't there be tests for those as well? (The only tests are
for PRIV_TASK.)
The patch doesn't provide for the use of PRIV_CALL in a method, which
makes sense because you don't need that for an object (just store your
private data in the object). But someone might declare PRIV_CALL for a
method in their vcc spec anyway. I think the right thing in that case
would be for the vmodtool to an emit error with a helpful hint. (Otherwise
what would happen? The same vgc compile-time error that I encountered
above?)
--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1800#comment:7>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator
More information about the varnish-bugs
mailing list