[Varnish] #1750: Fail more gracefully on -l >= 4GB
Varnish
varnish-bugs at varnish-cache.org
Tue Feb 2 16:24:25 CET 2016
#1750: Fail more gracefully on -l >= 4GB
----------------------+----------------------------------
Reporter: geoff | Owner: martin
Type: defect | Status: new
Priority: low | Milestone: Varnish 4.0 release
Component: varnishd | Version: 4.0.3
Severity: minor | Resolution:
Keywords: |
----------------------+----------------------------------
Comment (by geoff):
size_t is a "natural" type for something like that, and is almost
certainly large enough for anything that anyone might want to have for -l.
But there's also the matter of graceful failure. It would still be
necessary to reject -l values that are too large (> SIZE_MAX in the case
of size_t), and the reasonable expectation would be that varnish doesn't
start at all, neither master or child process, as soon as the command line
parsed, with a message to stderr.
As it is, the master process starts when -l is too large, but the child
process is aborted and then the master process stops. A message about the
abort goes to syslog, but nothing says what the problem was. Automated
deployments see the master process starting, and then have every reason to
assume that everything's fine.
--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1750#comment:4>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator
More information about the varnish-bugs
mailing list