r559 - in trunk/varnish-cache: bin/varnishd include lib/libvcl

Poul-Henning Kamp phk at phk.freebsd.dk
Sun Jul 23 00:18:11 CEST 2006

In message <ujrfygtfi79.fsf at cat.linpro.no>, Dag-Erling =?iso-8859-1?Q?Sm=F8rgra
v?= writes:
>phk at projects.linpro.no writes:
>> Log:
>> Implement regexp matching of strings in VCL.
>> For now we default to REG_EXTENDED, but it might make sense
>> to let the user control this flag and the case sensitivity.
>> Another concern is the stringification of regexps, it may lead
>> to backslash madness.  Maybe we should define '...' string types
>> also and do no backslash substitution in those at all.
>How about using the syntax used in ed / sed / ex / vi / perl etc,
>i.e. /regex/?

That would force '/' to be escaped and it is heavily used in URLS.

I may have overlooked the obvious however:  the current backslash
processing on CSTR ("...") is not actually called for as far as
I can see, so maybe removing that is a much better idea.

The reason I put it in there was for HTML error messages, but
they need to be handled more sensibly than that.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-commit mailing list