r1072 - trunk/varnish-cache/bin/varnishd

[phk at projects.linpro.no]

Author: phk
Date: 2006-09-18 12:38:13 +0200 (Mon, 18 Sep 2006)
New Revision: 1072

Modified:
   trunk/varnish-cache/bin/varnishd/cache_center.c
   trunk/varnish-cache/bin/varnishd/cache_pool.c
Log:
Add a couple of XXX comments


Modified: trunk/varnish-cache/bin/varnishd/cache_center.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_center.c	2006-09-18 10:21:49 UTC (rev 1071)
+++ trunk/varnish-cache/bin/varnishd/cache_center.c	2006-09-18 10:38:13 UTC (rev 1072)
@@ -303,6 +303,13 @@
 {
 	int i;
 
+	/*
+	 * XXX: If we don't have acceptfilters we are somewhat subject
+	 * XXX: to DoS'ing here.  One remedy would be to set a shorter
+	 * XXX: SO_RCVTIMEO and once we have received something here
+	 * XXX: increase it to the normal value.
+	 */
+
 	assert(sp->xid == 0);
 	VCA_Prep(sp);
 	sp->wrk->idle = sp->t_open.tv_sec;

Modified: trunk/varnish-cache/bin/varnishd/cache_pool.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_pool.c	2006-09-18 10:21:49 UTC (rev 1071)
+++ trunk/varnish-cache/bin/varnishd/cache_pool.c	2006-09-18 10:38:13 UTC (rev 1072)
@@ -275,6 +275,12 @@
 	UNLOCK(&qp->mtx);
 
 	LOCK(&tmtx);
+	/*
+	 * XXX: If there are too many requests in the overflow queue
+	 * XXX: we should kill the request right here. 
+	 * XXX: Not sure how though.  Simply closing may be the better
+	 * XXX: compromise.
+	 */
 	TAILQ_INSERT_TAIL(&overflow, &sp->workreq, list);
 	VSL_stats->n_wrk_overflow++;
 	VSL_stats->n_wrk_queue++;