r1850 - trunk/varnish-tools/regress/lib/Varnish/Test
Dag-Erling Smørgrav
des at linpro.no
Thu Aug 16 15:16:19 CEST 2007
knutroy at projects.linpro.no writes:
> Log:
> * Added automatic shutdown of Client-objects used by a test.
> * Added more diagnostic messages wrt. left-over input data/junk.
Thanks, just one nit:
> @@ -145,6 +145,15 @@
> sub shutdown($) {
> my ($self) = @_;
>
> + my $inbuffer = $self->{'mux'}->inbuffer($self->{'fh'});
> +
> + if ($inbuffer ne '') {
> + use Data::Dumper;
> +
> + $self->{'server'}->log('Junk or incomplete request. Discarding: ' . Dumper(\$inbuffer));
> + $self->{'mux'}->inbuffer($self->{'fh'}, '');
> + }
> +
> $self->{'mux'}->close($self->{'fh'});
> }
>
> @@ -224,8 +233,12 @@
> # of request, so if there is anything left in input buffer, it
> # must be incomplete because "mux_input" left it there.
>
> - die "Junk or incomplete request\n"
> - unless $$data eq '';
> + if ($$data ne '') {
> + use Data::Dumper;
> +
> + $self->{'server'}->log('Junk or incomplete request. Discarding: ' . Dumper($data));
> + $$data = '';
> + }
> }
might as well move use Data::Dumper to the top of the package...
DES
--
Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no
More information about the varnish-commit
mailing list