r2287 - in trunk/varnish-cache: bin/varnishd bin/varnishlog bin/varnishtop include lib/libvarnishapi

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Dec 12 19:36:38 CET 2007


In message <ujrk5nkkvw7.fsf at false.linpro.no>, =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= writes:
>phk at projects.linpro.no writes:
>> +#define SHMLOG_TAG	0
>> +#define __SHMLOG_LEN_HIGH	1
>> +#define __SHMLOG_LEN_LOW	2
>> +#define __SHMLOG_ID_HIGH	3
>> +#define __SHMLOG_ID_LOW	4
>> +#define SHMLOG_DATA	5
>> +#define SHMLOG_NEXTTAG	6	/* ... + len */
>
>We should not use names that begin with underscores.

I used double underscores to indicate that these constants should not be
used outside designated areas.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



More information about the varnish-commit mailing list