r2232 - trunk/varnish-cache/bin/varnishd

[Poul-Henning Kamp]

In message <ujrzlxnlmia.fsf at false.linpro.no>, =?iso-8859-1?Q?Dag-Erling_Sm=F8rg
rav?= writes:
>"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
>> In message <ujr4pfvn1dt.fsf at false.linpro.no>, =3D?iso-8859-1?Q?Dag-Erling=
>_Sm=3DF8rg
>> rav?=3D writes:
>> > - kevent changes can be buffered safely if we flush the buffer at the
>> >   end of the loop in vca_kqueue_main().  Since we process (at most)
>> >   NKEV kevents at a time, we will never have more than NKEV kevent
>> >   changes to apply at that point, so it's safe to use a static
>> >   buffer.
>> That's not true.  We can receive multiple sessions in one read from
>> the pipe.
>
>Ah, right.  So we flush the buffer when it's full, plus at the end of
>the loop.

Yes.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.