r2128 - trunk/varnish-tools/regress/lib/Varnish/Test/Case
des at projects.linpro.no
des at projects.linpro.no
Fri Oct 19 11:35:09 CEST 2007
Author: des
Date: 2007-10-19 11:35:09 +0200 (Fri, 19 Oct 2007)
New Revision: 2128
Modified:
trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
Log:
The framework bugs which used to affect this test case have long since
been fixed, so remove the workarounds. Also stop testing things which
are not intended to work.
Modified: trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
===================================================================
--- trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-10-19 09:09:42 UTC (rev 2127)
+++ trunk/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm 2007-10-19 09:35:09 UTC (rev 2128)
@@ -36,15 +36,6 @@
our $DESCR = "Tests Varnish's ability to correctly pass POST requests" .
" to the backend, and their replies back to the client.";
-# testCachePOST and testPassPOST are known to fail, and it is not
-# clear at this point whether that is a bug or a feature.
-#
-# More interestingly, if you run testPassPOST before testPipePOST, the
-# latter receives the Varnish Guru Meditation intended for the former.
-# This seems to be a bug in either IO::Multiplex or Varnish::Test.
-#
-our @TESTS = qw(testPipePOST testCachePOST testPassPOST);
-
our $VCL = <<EOVCL;
sub vcl_recv {
if (req.request == "POST") {
@@ -113,6 +104,10 @@
sub server_get($$$) {
my ($self, $request, $response) = @_;
+ # Varnish will always use GET when fetching a presumably cacheable
+ # object from the backend. This is not a bug.
+ goto &server_post
+ if ($request->uri =~ m/cache_me/);
die "Got GET request instead of POST\n";
}
More information about the varnish-commit
mailing list