r2614 - trunk/varnish-cache/bin/varnishd

[Anders Nordby]

Hi,

I mentioned to des previously that by going from trunk 2605 to 2614, my
load and level of context switches per second grew a lot (during peaks),
and sent a couple of graphs showing that.

I've now tracked the problem down to this particular patch. I can run
with the latest trunk (2629), and by removing this changeset, my load
and context switches graphs are like before.

Could you and/or Arjan please take look at this change again please.
Running with or without -s malloc (which I've also been playing with
lately) does not seem to make a difference, only applying/removing this
changeset does.

PS2: I recently heard des' talk on "Light My Fire". Is there any chance
it could catch things like this, changes that give a distinct and
negative impact on performance?

Bye,
Anders.

On Mon, Mar 31, 2008 at 01:49:21PM +0200, phk at projects.linpro.no wrote:
> Author: phk
> Date: 2008-03-31 13:49:20 +0200 (Mon, 31 Mar 2008)
> New Revision: 2614
> 
> Modified:
>    trunk/varnish-cache/bin/varnishd/cache_hash.c
> Log:
> Fix a memoryleak relating to hash strings, found by: Arjan (noosius).
> 
> 
> 
> Modified: trunk/varnish-cache/bin/varnishd/cache_hash.c
> ===================================================================
> --- trunk/varnish-cache/bin/varnishd/cache_hash.c	2008-03-31 11:47:15 UTC (rev 2613)
> +++ trunk/varnish-cache/bin/varnishd/cache_hash.c	2008-03-31 11:49:20 UTC (rev 2614)
> @@ -383,6 +383,7 @@
>  	assert(VTAILQ_EMPTY(&oh->objects));
>  	MTX_DESTROY(&oh->mtx);
>  	VSL_stats->n_objecthead--;
> +	free(oh->hash);
>  	FREE_OBJ(oh);
>  }
>  
> 
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at projects.linpro.no
> http://projects.linpro.no/mailman/listinfo/varnish-commit


-- 
Anders.