r2943 - in trunk/varnish-cache: bin/varnishd bin/varnishtest/tests include lib/libvcl

Dag-Erling Smørgrav des at linpro.no
Wed Jul 16 11:00:25 CEST 2008


petter at projects.linpro.no writes:
> Added a round robin director. The round robin director can be created like this:
>
> director batman round-robin {
> 	{ .backend = b1; }
> 	{ .backend = b2; }
> 	{ .backend = b3; }
> }

We should avoid the use of non-word characters in VCL keywords (using
Perl's definition of a word character, [0-9A-Za-z_]), so this should be
"round_robin" or "roundrobin".

> + * Copyright (c) 2006 Verdens Gang AS
> + * Copyright (c) 2006-2008 Linpro AS
> + * All rights reserved.

This is a new file, it should have "Copyright (c) 2008 Linpro AS" and no
VG copyright.

> +	for (nelem = 0; tl->t->tok != '}'; nelem++) {	/* List of members */

Code comments go on separate lines

This (and directors in general) should be documented in vcl(7).

DES
-- 
Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no



More information about the varnish-commit mailing list