r3826 - in trunk/varnish-cache/bin/varnishtest: . tests

tfheen at projects.linpro.no tfheen at projects.linpro.no
Wed Feb 25 11:50:49 CET 2009


Author: tfheen
Date: 2009-02-25 11:50:49 +0100 (Wed, 25 Feb 2009)
New Revision: 3826

Modified:
   trunk/varnish-cache/bin/varnishtest/tests/a00009.vtc
   trunk/varnish-cache/bin/varnishtest/vtc.c
Log:
Make sure system "..." returns successfully

We didn't check the return status of system, making failures in a00009
go unnoticed.  Fix this and fix a00009 to not fail when run
uninstalled.


Modified: trunk/varnish-cache/bin/varnishtest/tests/a00009.vtc
===================================================================
--- trunk/varnish-cache/bin/varnishtest/tests/a00009.vtc	2009-02-25 10:25:43 UTC (rev 3825)
+++ trunk/varnish-cache/bin/varnishtest/tests/a00009.vtc	2009-02-25 10:50:49 UTC (rev 3826)
@@ -2,4 +2,4 @@
 
 test "See that the VCL compiler works"
 
-shell "cd ../varnishd && ./varnishd -b 127.0.0.1:80 -C"
+shell "cd ../varnishd && ./varnishd -b 127.0.0.1:80 -C -n /tmp/__v1"

Modified: trunk/varnish-cache/bin/varnishtest/vtc.c
===================================================================
--- trunk/varnish-cache/bin/varnishtest/vtc.c	2009-02-25 10:25:43 UTC (rev 3825)
+++ trunk/varnish-cache/bin/varnishtest/vtc.c	2009-02-25 10:50:49 UTC (rev 3826)
@@ -246,7 +246,7 @@
 	AN(av[1]);
 	AZ(av[2]);
 	vtc_dump(vl, 4, "shell", av[1]);
-	(void)system(av[1]);	/* XXX: assert ? */
+	assert(WEXITSTATUS(system(av[1])) == 0);
 }
 
 /**********************************************************************



More information about the varnish-commit mailing list