r4145 - trunk/varnish-cache/bin/varnishd

[sky at projects.linpro.no]

Author: sky
Date: 2009-07-27 11:54:31 +0200 (Mon, 27 Jul 2009)
New Revision: 4145

Modified:
   trunk/varnish-cache/bin/varnishd/cache_expire.c
Log:
reminder to add test case to catch this error

Modified: trunk/varnish-cache/bin/varnishd/cache_expire.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_expire.c	2009-07-17 09:45:27 UTC (rev 4144)
+++ trunk/varnish-cache/bin/varnishd/cache_expire.c	2009-07-27 09:54:31 UTC (rev 4145)
@@ -334,6 +334,11 @@
 	if (oc == NULL)
 		return (-1);
 
+	/* o is never allocated so this shouldn't work
+	 * making a comment so I don't forget
+	 * why does no test case capture this?
+	 * could be my swine flu riddled mind playing games? / Artur
+	 */
 	WSL(sp->wrk, SLT_ExpKill, 0, "%u LRU", o->xid);
 	HSH_Deref(sp->wrk, &o);
 	return (1);