r4547 - trunk/varnish-cache/bin/varnishd
phk at projects.linpro.no
phk at projects.linpro.no
Wed Feb 10 13:38:34 CET 2010
Author: phk
Date: 2010-02-10 13:38:34 +0100 (Wed, 10 Feb 2010)
New Revision: 4547
Modified:
trunk/varnish-cache/bin/varnishd/cache_center.c
Log:
Comments with a warning I came close to forgetting
Modified: trunk/varnish-cache/bin/varnishd/cache_center.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_center.c 2010-02-10 11:00:35 UTC (rev 4546)
+++ trunk/varnish-cache/bin/varnishd/cache_center.c 2010-02-10 12:38:34 UTC (rev 4547)
@@ -789,8 +789,8 @@
* We lost the session to a busy object, disembark the
* worker thread. The hash code to restart the session,
* still in STP_LOOKUP, later when the busy object isn't.
+ * NB: Do not access sp any more !
*/
- AZ(sp->wrk);
return (1);
}
@@ -1217,6 +1217,9 @@
if (sp->step == STP_FIRST || sp->step == STP_START)
TCP_blocking(sp->fd);
+ /*
+ * NB: Once done is set, we can no longer touch sp!
+ */
for (done = 0; !done; ) {
assert(sp->wrk == w);
/*
More information about the varnish-commit
mailing list