r4576 - in trunk/varnish-cache: bin/varnishd lib/libvarnish

phk at projects.linpro.no phk at projects.linpro.no
Wed Feb 17 20:07:24 CET 2010


Author: phk
Date: 2010-02-17 20:07:21 +0100 (Wed, 17 Feb 2010)
New Revision: 4576

Modified:
   trunk/varnish-cache/bin/varnishd/cache_center.c
   trunk/varnish-cache/bin/varnishd/cache_fetch.c
   trunk/varnish-cache/bin/varnishd/cache_pipe.c
   trunk/varnish-cache/bin/varnishd/cache_waiter_kqueue.c
   trunk/varnish-cache/bin/varnishd/cache_waiter_poll.c
   trunk/varnish-cache/bin/varnishd/mgt_child.c
   trunk/varnish-cache/lib/libvarnish/tcp.c
   trunk/varnish-cache/lib/libvarnish/vss.c
Log:
Tell FlexeLint that we ignore returnvalues on purpose.



Modified: trunk/varnish-cache/bin/varnishd/cache_center.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_center.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/bin/varnishd/cache_center.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -271,7 +271,7 @@
 		 * This is an orderly close of the connection; ditch nolinger
 		 * before we close, to get queued data transmitted.
 		 */
-		TCP_linger(sp->fd, 0);
+		(void)TCP_linger(sp->fd, 0);
 		vca_close_session(sp, sp->doclose);
 	}
 
@@ -1216,7 +1216,7 @@
 	 * do the syscall in the worker thread.
 	 */
 	if (sp->step == STP_FIRST || sp->step == STP_START)
-		TCP_blocking(sp->fd);
+		(void)TCP_blocking(sp->fd);
 
 	/*
 	 * NB: Once done is set, we can no longer touch sp!

Modified: trunk/varnish-cache/bin/varnishd/cache_fetch.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_fetch.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/bin/varnishd/cache_fetch.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -367,7 +367,7 @@
 	if (!http_GetHdr(hp, H_Host, &b))
 		VBE_AddHostHeader(sp);
 
-	TCP_blocking(vc->fd);	/* XXX: we should timeout instead */
+	(void)TCP_blocking(vc->fd);	/* XXX: we should timeout instead */
 	WRW_Reserve(w, &vc->fd);
 	(void)http_Write(w, hp, 0);	/* XXX: stats ? */
 

Modified: trunk/varnish-cache/bin/varnishd/cache_pipe.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_pipe.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/bin/varnishd/cache_pipe.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -79,7 +79,7 @@
 	if (sp->vbe == NULL)
 		return;
 	vc = sp->vbe;
-	TCP_blocking(vc->fd);
+	(void)TCP_blocking(vc->fd);
 
 	WRW_Reserve(w, &vc->fd);
 	sp->acct_req.hdrbytes += http_Write(w, sp->wrk->bereq, 0);
@@ -100,11 +100,11 @@
 
 	memset(fds, 0, sizeof fds);
 
-	TCP_linger(vc->fd, 0);
+	(void)TCP_linger(vc->fd, 0);
 	fds[0].fd = vc->fd;
 	fds[0].events = POLLIN | POLLERR;
 
-	TCP_linger(sp->fd, 0);
+	(void)TCP_linger(sp->fd, 0);
 	fds[1].fd = sp->fd;
 	fds[1].events = POLLIN | POLLERR;
 

Modified: trunk/varnish-cache/bin/varnishd/cache_waiter_kqueue.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_waiter_kqueue.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/bin/varnishd/cache_waiter_kqueue.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -198,7 +198,7 @@
 			if (sp->t_open > deadline)
 				break;
 			VTAILQ_REMOVE(&sesshead, sp, list);
-			TCP_linger(sp->fd, 0);
+			(void)TCP_linger(sp->fd, 0);
 			vca_close_session(sp, "timeout");
 			SES_Delete(sp);
 		}

Modified: trunk/varnish-cache/bin/varnishd/cache_waiter_poll.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/cache_waiter_poll.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/bin/varnishd/cache_waiter_poll.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -166,7 +166,7 @@
 			} else if (sp->t_open <= deadline) {
 				VTAILQ_REMOVE(&sesshead, sp, list);
 				vca_unpoll(fd);
-				TCP_linger(sp->fd, 0);
+				(void)TCP_linger(sp->fd, 0);
 				vca_close_session(sp, "timeout");
 				SES_Delete(sp);
 			}

Modified: trunk/varnish-cache/bin/varnishd/mgt_child.c
===================================================================
--- trunk/varnish-cache/bin/varnishd/mgt_child.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/bin/varnishd/mgt_child.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -206,7 +206,7 @@
 		 * closes before we call accept(2) and nobody else are in
 		 * the listen queue to release us.
 		 */
-		TCP_nonblocking(ls->sock);
+		(void)TCP_nonblocking(ls->sock);
 		(void)TCP_filter_http(ls->sock);
 		good++;
 	}

Modified: trunk/varnish-cache/lib/libvarnish/tcp.c
===================================================================
--- trunk/varnish-cache/lib/libvarnish/tcp.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/lib/libvarnish/tcp.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -196,7 +196,7 @@
 	assert(s >= 0);
 
 	/* Set the socket non-blocking */
-	TCP_nonblocking(s);
+	(void)TCP_nonblocking(s);
 
 	/* Attempt the connect */
 	i = connect(s, name, namelen);
@@ -224,7 +224,7 @@
 	if (k)
 		return (-1);
 
-	TCP_blocking(s);
+	(void)TCP_blocking(s);
 	return (0);
 }
 

Modified: trunk/varnish-cache/lib/libvarnish/vss.c
===================================================================
--- trunk/varnish-cache/lib/libvarnish/vss.c	2010-02-17 19:03:08 UTC (rev 4575)
+++ trunk/varnish-cache/lib/libvarnish/vss.c	2010-02-17 19:07:21 UTC (rev 4576)
@@ -250,7 +250,7 @@
 		return (-1);
 	}
 	if (nonblock)
-		TCP_nonblocking(sd);
+		(void)TCP_nonblocking(sd);
 	i = connect(sd, &va->va_addr.sa, va->va_addrlen);
 	if (i == 0 || (nonblock && errno == EINPROGRESS))
 		return (sd);



More information about the varnish-commit mailing list