[master] 0d03ebb Remove an old wart of dubious origin. I belive that this originally was related to the entry parameters of cnt_error(), but I belive it has long been OBE, and now gets in the way of streaming.

Poul-Henning Kamp phk at varnish-cache.org
Mon Jan 23 20:55:49 CET 2012


commit 0d03ebb6b68fa50d88463566a40bb341698ec559
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Jan 23 19:54:31 2012 +0000

    Remove an old wart of dubious origin.  I belive that this originally
    was related to the entry parameters of cnt_error(), but I belive it
    has long been OBE, and now gets in the way of streaming.

diff --git a/bin/varnishd/cache/cache_fetch.c b/bin/varnishd/cache/cache_fetch.c
index 7070612..28de3b6 100644
--- a/bin/varnishd/cache/cache_fetch.c
+++ b/bin/varnishd/cache/cache_fetch.c
@@ -578,12 +578,6 @@ FetchBody(struct worker *wrk, struct object *obj)
 
 	if (cls < 0) {
 		wrk->stats.fetch_failed++;
-		/* XXX: Wouldn't this store automatically be released ? */
-		while (!VTAILQ_EMPTY(&obj->store)) {
-			st = VTAILQ_FIRST(&obj->store);
-			VTAILQ_REMOVE(&obj->store, st, list);
-			STV_free(st);
-		}
 		VDI_CloseFd(wrk, &bo->vbc);
 		obj->len = 0;
 		return (__LINE__);



More information about the varnish-commit mailing list