[master] 74e2d3f Seems I have either hit a GCC bug or a lack of imagination in the C-standardisation. (Even money if you ask me...)

Poul-Henning Kamp phk at varnish-cache.org
Tue Jul 3 14:33:53 CEST 2012


commit 74e2d3f3dc50967a64fe818f7fcb78af06f76e1a
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Tue Jul 3 12:33:09 2012 +0000

    Seems I have either hit a GCC bug or a lack of imagination in the
    C-standardisation.  (Even money if you ask me...)
    
    GCC users will just have to live with marginally works docs.

diff --git a/include/tbl/vsl_tags.h b/include/tbl/vsl_tags.h
index 27fed4d..37c2e6b 100644
--- a/include/tbl/vsl_tags.h
+++ b/include/tbl/vsl_tags.h
@@ -80,7 +80,13 @@ SLTM(SessOpen, "Client connection opened",
 SLTM(SessClose, "Client connection closed",
 	"SessionClose is the last record for any client connection.\n\n"
 	"reason\n    Why the connection closed.\n\n"
+#ifdef __clang__
+/*
+ * GCC barfs at this construct, but we have no way to ask compiler
+ * if it is _not_ a GCC compiler since CLANG also defines __GNUC__
+ */
 #include <tbl/sess_close.h>
+#endif
 	"duration\n    How long the session were open.\n\n"
 	"Nreq\n    How many requests on session.\n\n"
 	"Npipe\n    If 'pipe' were used on session.\n\n"



More information about the varnish-commit mailing list