[master] cb3e952 Treat error as miss + error in %{Varnish:handling}x format

Tollef Fog Heen tfheen at varnish-cache.org
Mon Mar 11 12:14:45 CET 2013


commit cb3e952b4346e34dbf425b67ca667928d927c59b
Author: Tollef Fog Heen <tfheen at varnish-software.com>
Date:   Mon Mar 11 12:13:56 2013 +0100

    Treat error as miss + error in %{Varnish:handling}x format
    
    Fixes #1273

diff --git a/bin/varnishncsa/varnishncsa.c b/bin/varnishncsa/varnishncsa.c
index 309019d..0b039b6 100644
--- a/bin/varnishncsa/varnishncsa.c
+++ b/bin/varnishncsa/varnishncsa.c
@@ -521,6 +521,11 @@ collect_client(struct logline *lp, enum VSL_tag_e tag, unsigned spec,
 		} else if (strncmp(ptr, "pass", len) == 0) {
 			lp->df_hitmiss = "miss";
 			lp->df_handling = "pass";
+		} else if (strncmp(ptr, "error", len) == 0) {
+			/* Arguably, error isn't a hit or a miss, but
+			 miss is less wrong */
+			lp->df_hitmiss = "miss";
+			lp->df_handling = "error";
 		} else if (strncmp(ptr, "pipe", len) == 0) {
 			/* Just skip piped requests, since we can't
 			 * print their status code */



More information about the varnish-commit mailing list