[master] 92f175d Fix old code which did not follow the times.

Poul-Henning Kamp phk at varnish-cache.org
Tue Oct 1 17:34:18 CEST 2013


commit 92f175d94ee6acf3b5b21950fd05e52ed3c616f6
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Tue Oct 1 15:33:59 2013 +0000

    Fix old code which did not follow the times.
    
    Spotted by: Coverity

diff --git a/bin/varnishd/cache/cache_panic.c b/bin/varnishd/cache/cache_panic.c
index c79a1bb..3258033 100644
--- a/bin/varnishd/cache/cache_panic.c
+++ b/bin/varnishd/cache/cache_panic.c
@@ -348,9 +348,7 @@ pan_sess(const struct sess *sp)
 	VSB_printf(pan_vsp, "  sp = %p {\n", sp);
 	VSB_printf(pan_vsp, "    fd = %d, vxid = %u,\n",
 	    sp->fd, sp->vxid & VSL_IDENTMASK);
-	VSB_printf(pan_vsp, "    client = %s %s,\n",
-	    sp->addr ? sp->addr : "?.?.?.?",
-	    sp->port ? sp->port : "?");
+	VSB_printf(pan_vsp, "    client = %s %s,\n", sp->addr, sp->port);
 	switch (sp->sess_step) {
 #define SESS_STEP(l, u) case S_STP_##u: stp = "S_STP_" #u; break;
 #include "tbl/steps.h"



More information about the varnish-commit mailing list