[master] 1e94b37 This AZ introduced the opposite race of the one it was supposed to check: The req might get rescheduled before we get there.

Poul-Henning Kamp phk at varnish-cache.org
Fri Oct 4 10:34:19 CEST 2013


commit 1e94b37816156667d7471a3df6e74f1275923bbc
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Fri Oct 4 08:33:51 2013 +0000

    This AZ introduced the opposite race of the one it was supposed
    to check:  The req might get rescheduled before we get there.

diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c
index 9e1609b..c20aa83 100644
--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -884,7 +884,6 @@ CNT_Request(struct worker *wrk, struct req *req)
 		req->wrk = NULL;
 	}
 
-	AZ(req->wrk);
 	assert(WRW_IsReleased(wrk));
 	return (nxt);
 }



More information about the varnish-commit mailing list