[master] 7e2ac56 Add an XXX comment about turning off unnecessary timestamps

Martin Blix Grydeland martin at varnish-software.com
Wed Mar 26 12:42:22 CET 2014


commit 7e2ac56eee82982ea7d0e65c4bd9b12f23fea543
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Tue Mar 25 17:16:15 2014 +0100

    Add an XXX comment about turning off unnecessary timestamps

diff --git a/bin/varnishd/cache/cache_shmlog.c b/bin/varnishd/cache/cache_shmlog.c
index 900ecda..af78bfa 100644
--- a/bin/varnishd/cache/cache_shmlog.c
+++ b/bin/varnishd/cache/cache_shmlog.c
@@ -355,6 +355,10 @@ VSLb_ts(struct vsl_log *vsl, const char *event, double first, double *pprev,
     double now)
 {
 
+	/* XXX: Make an option to turn off some unnecessary timestamp
+	   logging. This must be done carefully because some functions
+	   (e.g. WRW_Reserve) takes the last timestamp as it's inital
+	   value for timeout calculation. */
 	assert(!isnan(now) && now != 0.);
 	VSLb(vsl, SLT_Timestamp, "%s: %.6f %.6f %.6f",
 	    event, now, now - first, now - *pprev);



More information about the varnish-commit mailing list