[4.0] 4ddf0ee Remove a racy assertion on the OC_EF_DYING state

Lasse Karstensen lkarsten at varnish-software.com
Wed Feb 11 13:24:23 CET 2015

commit 4ddf0eef791a030694380fbb6736d87a43813c16
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Wed Feb 11 12:02:54 2015 +0100

    Remove a racy assertion on the OC_EF_DYING state
    This state could be set by the expiry timer even though a reference is
    grabbed during lookup, causing the assertion to trigger.
    Fixes: #1539

diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c
index 88eaa53..40551f7 100644
--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -427,7 +427,6 @@ cnt_lookup(struct worker *wrk, struct req *req)
 		if (boc != NULL) {
 			AZ(oc->flags & OC_F_PASS);
-			AZ(oc->exp_flags & OC_EF_DYING);
 			VBF_Fetch(wrk, req, boc, o, VBF_BACKGROUND);
 		} else {

More information about the varnish-commit mailing list