[master] 6ca1aef Don't double-free.

Poul-Henning Kamp phk at FreeBSD.org
Thu Oct 22 20:01:06 CEST 2015


commit 6ca1aef16add038f8427ed142434e760d1b3c600
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Thu Oct 22 18:00:41 2015 +0000

    Don't double-free.
    
    Amazingly JEMALLOC didn't spot this one.

diff --git a/bin/varnishd/cache/cache_ban_build.c b/bin/varnishd/cache/cache_ban_build.c
index bec9062..b807c9a 100644
--- a/bin/varnishd/cache/cache_ban_build.c
+++ b/bin/varnishd/cache/cache_ban_build.c
@@ -92,8 +92,6 @@ BAN_Abandon(struct ban_proto *bp)
 
 	CHECK_OBJ_NOTNULL(bp, BAN_PROTO_MAGIC);
 	VSB_delete(bp->vsb);
-	if (bp->err != NULL && bp->err != ban_build_err_no_mem)
-		free(bp->err);
 	FREE_OBJ(bp);
 }
 



More information about the varnish-commit mailing list