[master] 76b6a04 Pointlessly fix a resource-leak in bail-out path, spotted by Coverity.

Poul-Henning Kamp phk at FreeBSD.org
Tue Aug 30 00:35:09 CEST 2016


commit 76b6a042eb04c169ae2e6cdc8d0c7e073a56d819
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Aug 29 22:24:40 2016 +0000

    Pointlessly fix a resource-leak in bail-out path, spotted by Coverity.

diff --git a/lib/libvcc/vcc_acl.c b/lib/libvcc/vcc_acl.c
index 7c7ec97..10d4ffa 100644
--- a/lib/libvcc/vcc_acl.c
+++ b/lib/libvcc/vcc_acl.c
@@ -225,6 +225,8 @@ vcc_acl_try_getaddrinfo(struct vcc *tl, struct acl_e *ae)
 				res->ai_family, PF(ae->t_addr));
 			continue;
 		}
+		if (tl->err)
+			freeaddrinfo(res0);
 		ERRCHK(tl);
 	}
 	freeaddrinfo(res0);



More information about the varnish-commit mailing list