[master] d90f39d VRB_PROTOTYPE_* and VRB_GENERATE_* macros are not to be used as staments

Nils Goroll nils.goroll at uplex.de
Thu Dec 8 13:39:04 CET 2016


commit d90f39d54e091c9c2395616bcb078e5757e40e25
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Thu Dec 8 13:35:19 2016 +0100

    VRB_PROTOTYPE_* and VRB_GENERATE_* macros are not to be used as staments
    
    It took me way too long to understand that empty declarations
    found by suncc were caused by the extra ;

diff --git a/bin/varnishtop/varnishtop.c b/bin/varnishtop/varnishtop.c
index ff2c40c..eccb4ca 100644
--- a/bin/varnishtop/varnishtop.c
+++ b/bin/varnishtop/varnishtop.c
@@ -109,10 +109,10 @@ static int f_flag = 0;
 
 static unsigned maxfieldlen = 0;
 
-VRB_PROTOTYPE_STATIC(t_order, top, e_order, cmp_order);
-VRB_GENERATE_STATIC(t_order, top, e_order, cmp_order);
-VRB_PROTOTYPE_STATIC(t_key, top, e_key, cmp_key);
-VRB_GENERATE_STATIC(t_key, top, e_key, cmp_key);
+VRB_PROTOTYPE_STATIC(t_order, top, e_order, cmp_order)
+VRB_GENERATE_STATIC(t_order, top, e_order, cmp_order)
+VRB_PROTOTYPE_STATIC(t_key, top, e_key, cmp_key)
+VRB_GENERATE_STATIC(t_key, top, e_key, cmp_key)
 
 static int __match_proto__(VSLQ_dispatch_f)
 accumulate(struct VSL_data *vsl, struct VSL_transaction * const pt[],



More information about the varnish-commit mailing list