[4.1] 78a0ecd VFP_Push: document the place which still need attention for out-of-workspace handling

Lasse Karstensen lkarsten at varnish-software.com
Thu Feb 25 15:11:14 CET 2016


commit 78a0ecdcb02f5201120a1b8fab5794ce4d974688
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Wed Feb 17 14:17:42 2016 +0100

    VFP_Push: document the place which still need attention for out-of-workspace handling
    
    We'll need to change a couple of signatures in the call paths getting here
    to propagate up the failure.

diff --git a/bin/varnishd/http1/cache_http1_vfp.c b/bin/varnishd/http1/cache_http1_vfp.c
index fe99ebd..1c11384 100644
--- a/bin/varnishd/http1/cache_http1_vfp.c
+++ b/bin/varnishd/http1/cache_http1_vfp.c
@@ -272,16 +272,19 @@ V1F_Setup_Fetch(struct vfp_ctx *vfc, struct http_conn *htc)
 	case BS_EOF:
 		assert(htc->content_length == -1);
 		vfe = VFP_Push(vfc, &v1f_eof, 0);
+		XXXAN(vfe);
 		vfe->priv2 = 0;
 		break;
 	case BS_LENGTH:
 		assert(htc->content_length > 0);
 		vfe = VFP_Push(vfc, &v1f_straight, 0);
+		XXXAN(vfe);
 		vfe->priv2 = htc->content_length;
 		break;
 	case BS_CHUNKED:
 		assert(htc->content_length == -1);
 		vfe = VFP_Push(vfc, &v1f_chunked, 0);
+		XXXAN(vfe);
 		vfe->priv2 = -1;
 		break;
 	default:



More information about the varnish-commit mailing list