[4.1] 1666af6 Turn false-positive INCOMPL macros into WRONG ones

Lasse Karstensen lkarsten at varnish-software.com
Tue Jun 14 11:19:09 CEST 2016


commit 1666af69b0781257f5613c3b545ee8d655bfb16b
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Thu Mar 31 16:36:13 2016 +0200

    Turn false-positive INCOMPL macros into WRONG ones
    
    It also applies for the 4.1 and 4.0 series.
    
    Refs #1890

diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c
index 2540a74..d83f2eb 100644
--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -182,7 +182,7 @@ cnt_deliver(struct worker *wrk, struct req *req)
 			req->req_step = R_STP_SYNTH;
 			break;
 		default:
-			INCOMPL();
+			WRONG("Illegal return from vcl_deliver{}");
 		}
 
 		return (REQ_FSM_MORE);
@@ -471,7 +471,7 @@ cnt_lookup(struct worker *wrk, struct req *req)
 		req->req_step = R_STP_PASS;
 		break;
 	default:
-		INCOMPL();
+		WRONG("Illegal return from vcl_hash{}");
 	}
 
 	/* Drop our object, we won't need it */



More information about the varnish-commit mailing list