[master] 3426e8c Turn false-positive INCOMPL macros into WRONG ones

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Thu Mar 31 16:38:03 CEST 2016


commit 3426e8c14a5b91529309704f634e59962118c52d
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Thu Mar 31 16:36:13 2016 +0200

    Turn false-positive INCOMPL macros into WRONG ones
    
    It also applies for the 4.1 and 4.0 series.
    
    Refs #1890

diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c
index 03c8b2e..333083e 100644
--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -120,7 +120,7 @@ cnt_deliver(struct worker *wrk, struct req *req)
 			req->req_step = R_STP_SYNTH;
 			break;
 		default:
-			INCOMPL();
+			WRONG("Illegal return from vcl_deliver{}");
 		}
 
 		return (REQ_FSM_MORE);
@@ -472,7 +472,7 @@ cnt_lookup(struct worker *wrk, struct req *req)
 		req->req_step = R_STP_PASS;
 		break;
 	default:
-		INCOMPL();
+		WRONG("Illegal return from vcl_hash{}");
 	}
 
 	/* Drop our object, we won't need it */



More information about the varnish-commit mailing list