[master] ed7ca73 ban lurker: the olist can be empty when all bans got dup'ed

Nils Goroll nils.goroll at uplex.de
Mon May 2 14:08:04 CEST 2016


commit ed7ca73068ecc33ce18f582cf54b939c49d17851
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Fri Apr 22 15:35:12 2016 +0200

    ban lurker: the olist can be empty when all bans got dup'ed
    
    All bans on olist can get marked completed as duplicates while we're
    working on them, in particular as we start at an offset of
    ban_lurker_age.
    
    Fixes #1919

diff --git a/bin/varnishd/cache/cache_ban_lurker.c b/bin/varnishd/cache/cache_ban_lurker.c
index 65c552e..6d038bb 100644
--- a/bin/varnishd/cache/cache_ban_lurker.c
+++ b/bin/varnishd/cache/cache_ban_lurker.c
@@ -145,9 +145,6 @@ ban_lurker_test_ban(struct worker *wrk, struct vsl_log *vsl, struct ban *bt,
 	unsigned tests;
 	int i;
 
-	/* It's an error to give an empty list to test against */
-	AZ(VTAILQ_EMPTY(obans));
-
 	/*
 	 * First see if there is anything to do, and if so, insert marker
 	 */



More information about the varnish-commit mailing list