[4.1] a0c0481 ban lurker: the olist can be empty when all bans got dup'ed

PÃ¥l Hermunn Johansen hermunn at varnish-software.com
Tue May 3 15:03:04 CEST 2016


commit a0c0481e4f0f9e578e6a062645c62c6ebffe118e
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Fri Apr 22 15:35:12 2016 +0200

    ban lurker: the olist can be empty when all bans got dup'ed
    
    All bans on olist can get marked completed as duplicates while we're
    working on them, in particular as we start at an offset of
    ban_lurker_age.
    
    Fixes #1919

diff --git a/bin/varnishd/cache/cache_ban_lurker.c b/bin/varnishd/cache/cache_ban_lurker.c
index c3d4a19..ada0c05 100644
--- a/bin/varnishd/cache/cache_ban_lurker.c
+++ b/bin/varnishd/cache/cache_ban_lurker.c
@@ -145,9 +145,6 @@ ban_lurker_test_ban(struct worker *wrk, struct vsl_log *vsl, struct ban *bt,
 	unsigned tests;
 	int i;
 
-	/* It's an error to give an empty list to test against */
-	AZ(VTAILQ_EMPTY(obans));
-
 	/*
 	 * First see if there is anything to do, and if so, insert marker
 	 */



More information about the varnish-commit mailing list