[master] c4f4172 Note a todo for martin

Nils Goroll nils.goroll at uplex.de
Tue May 3 17:23:05 CEST 2016


commit c4f417261aab804a05e2490d1da378e81517f003
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Tue May 3 17:21:14 2016 +0200

    Note a todo for martin

diff --git a/bin/varnishd/cache/cache_ban.c b/bin/varnishd/cache/cache_ban.c
index 2d8f2db..6cd12f0 100644
--- a/bin/varnishd/cache/cache_ban.c
+++ b/bin/varnishd/cache/cache_ban.c
@@ -325,6 +325,8 @@ ban_export(void)
 void
 ban_info_new(const uint8_t *ban, unsigned len)
 {
+	/* XXX martin pls review if ban_mtx needs to be held */
+	Lck_AssertHeld(&ban_mtx);
 	if (STV_BanInfoNew(ban, len))
 		ban_export();
 }
@@ -332,6 +334,8 @@ ban_info_new(const uint8_t *ban, unsigned len)
 void
 ban_info_drop(const uint8_t *ban, unsigned len)
 {
+	/* XXX martin pls review if ban_mtx needs to be held */
+	Lck_AssertHeld(&ban_mtx);
 	if (STV_BanInfoDrop(ban, len))
 		ban_export();
 }



More information about the varnish-commit mailing list