[master] 8e04111 Autocrap de-cargo-culting

Poul-Henning Kamp phk at FreeBSD.org
Sat Nov 26 00:18:05 CET 2016


commit 8e041115fd94bc9a43ccc62043285b12379a459b
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Fri Nov 25 23:14:38 2016 +0000

    Autocrap de-cargo-culting
    
    We don't need AC_PROG_CPP, because we don't use the C preprocessor
    standalone for anything.
    
    It's not obvious that anybody needs AC_PROG_MAKE_SET ever, it looks
    like a band-aid for some crappy Win98-related tinker-toy-compiler.
    
    Amazing (or not...) that nobody in the autocrap community ever
    got the idea to add "What made AC_FOOBAR necessary" explanations
    to their documentation or changelogs.

diff --git a/configure.ac b/configure.ac
index bbbe55b..c101619 100644
--- a/configure.ac
+++ b/configure.ac
@@ -25,7 +25,6 @@ AC_PROG_LIBTOOL
 AC_GNU_SOURCE
 AC_PROG_CC
 AC_PROG_CC_STDC
-AC_PROG_CPP
 
 AX_PTHREAD(,[AC_MSG_ERROR([Could not configure pthreads support])])
 
@@ -34,7 +33,6 @@ CFLAGS="$CFLAGS $PTHREAD_CFLAGS"
 CC="$PTHREAD_CC"
 
 AC_PROG_INSTALL
-AC_PROG_MAKE_SET
 
 AC_ARG_WITH([rst2man],
   AS_HELP_STRING([--with-rst2man=PATH], [Location of rst2man (auto)]),
@@ -101,6 +99,7 @@ NET_LIBS="${LIBS}"
 LIBS="${save_LIBS}"
 AC_SUBST(NET_LIBS)
 
+# XXX: This _may_ be for OS/X
 AC_CHECK_LIBM
 AC_SUBST(LIBM)
 



More information about the varnish-commit mailing list