[master] ca8bd53 improve thread_pools documentation

Nils Goroll nils.goroll at uplex.de
Fri Sep 9 17:16:12 CEST 2016


commit ca8bd536e58589a208e9b855cdf726efd2a55675
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Fri Sep 9 16:31:03 2016 +0200

    improve thread_pools documentation

diff --git a/bin/varnishd/mgt/mgt_pool.c b/bin/varnishd/mgt/mgt_pool.c
index 327a4c2..7f0e78f 100644
--- a/bin/varnishd/mgt/mgt_pool.c
+++ b/bin/varnishd/mgt/mgt_pool.c
@@ -84,11 +84,14 @@ struct parspec WRK_parspec[] = {
 		"1", NULL,
 		"Number of worker thread pools.\n"
 		"\n"
-		"Increasing number of worker pools decreases lock "
-		"contention.\n"
+		"Increasing the number of worker pools decreases lock "
+		"contention. Each worker pool also has a thread accepting "
+		"new connections, so for very high rates of incoming new "
+		"connections on systems with many cores, increasing the "
+		"worker pools may be required.\n"
 		"\n"
-		"Too many pools waste CPU and RAM resources, and more than "
-		"one pool for each CPU is probably detrimal to performance.\n"
+		"Too many pools waste CPU and RAM resources, and more than one "
+		"pool for each CPU is most likely detrimal to performance.\n"
 		"\n"
 		"Can be increased on the fly, but decreases require a "
 		"restart to take effect.",
diff --git a/include/tbl/params.h b/include/tbl/params.h
index 57bab3a..475086c 100644
--- a/include/tbl/params.h
+++ b/include/tbl/params.h
@@ -1170,10 +1170,14 @@ PARAM(
 	/* s-text */
 	"Number of worker thread pools.\n"
 	"\n"
-	"Increasing number of worker pools decreases lock contention.\n"
+	"Increasing the number of worker pools decreases lock "
+	"contention. Each worker pool also has a thread accepting "
+	"new connections, so for very high rates of incoming new "
+	"connections on systems with many cores, increasing the "
+	"worker pools may be required.\n"
 	"\n"
 	"Too many pools waste CPU and RAM resources, and more than one "
-	"pool for each CPU is probably detrimal to performance.\n"
+	"pool for each CPU is most likely detrimal to performance.\n"
 	"\n"
 	"Can be increased on the fly, but decreases require a restart to "
 	"take effect.",



More information about the varnish-commit mailing list