[master] 2ddc4eb Be much more focused about 835 (Passing zero to operators like |, << etc.)

Poul-Henning Kamp phk at FreeBSD.org
Mon Apr 24 23:58:06 CEST 2017


commit 2ddc4eb916d8b493073390b74c3716bc7916d8bd
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Apr 24 21:57:22 2017 +0000

    Be much more focused about 835 (Passing zero to operators like |, << etc.)

diff --git a/bin/flint.lnt b/bin/flint.lnt
index d5f3dc3..55d2f4a 100644
--- a/bin/flint.lnt
+++ b/bin/flint.lnt
@@ -40,5 +40,3 @@
 -e726	// Extraneous comma ignored
 
 -e825	// control flows into case/default without -fallthrough comment
--e835	// A zero has been given as ___ argument to operator '___'  (<<)
-
diff --git a/bin/varnishd/flint.lnt b/bin/varnishd/flint.lnt
index e55dc34..eb21112 100644
--- a/bin/varnishd/flint.lnt
+++ b/bin/varnishd/flint.lnt
@@ -61,7 +61,17 @@
 
 -esym(458, params)	// unlocked access
 
--emacro(835, HTTPH)	// Info 835: A zero has been given as left argument to operator '&'
+-emacro(835, HCB_BIT_NODE)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, VBC_STATE_AVAIL)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, BANS_FLAG_REQ)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, HTTPH)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, HTTPH_R_PASS)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, SMP_SC_LOADED)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, SMP_SEG_MUSTLOAD)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, DELAYED_EFFECT)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, HDF_FILTER)	// Info 835: A zero has been given as left argument to operator '<<'
+-emacro(835, O_LARGEFILE)	// Info 835: A zero has been given as left argument to operator '<<'
+
 -emacro(845, HTTPH)	// Info 845: The left argument to operator '&&' is certain to be 0
 -esym(773, PCRE_DATE)	// Expression-like macro '___' not parenthesized
 //////////////
diff --git a/bin/varnishlog/flint.lnt b/bin/varnishlog/flint.lnt
index f2b336d..c29d6d4 100644
--- a/bin/varnishlog/flint.lnt
+++ b/bin/varnishlog/flint.lnt
@@ -1,4 +1,3 @@
--e835   // A zero has been given as ___ argument to operator '___'  (<<)
 -e712	// 14      Info    712     Loss of precision (___) (___ to ___)
 -e747	// 16      Info    747     Significant prototype coercion (___) ___ to ___
 
diff --git a/bin/varnishtest/flint.lnt b/bin/varnishtest/flint.lnt
index 9686e5f..6e82dd6 100644
--- a/bin/varnishtest/flint.lnt
+++ b/bin/varnishtest/flint.lnt
@@ -30,7 +30,8 @@
 -e737	// [45]  Loss of sign in promotion from int to unsigned
 -e713	// Loss of precision (assignment) (unsigned long long to long long)
 -e574	// Signed-unsigned mix with relational
--e835	//  A zero has been given as ___ argument to operator '___'  (<<)
+-emacro(835, STRTOU32_CHECK)    // A zero has been given as ___ argument to operator '___'
+
 -e788	// enum value not used in defaulted switch
 
 -efile(451, vmods.h)
diff --git a/flint.lnt b/flint.lnt
index 0876042..0cdded0 100644
--- a/flint.lnt
+++ b/flint.lnt
@@ -56,6 +56,16 @@
 -emacro(774, VALID_OBJ)		// boolean always true
 
 ///////////////////////////////////////////////////////////////////////
+// Places where we use x<<0 for reasons of symmetry
+
+-emacro(835, VCT_SP)		// A zero has been given as ___ argument to operator '___'
+-emacro(835, VSL_COPT_TAIL)	// A zero has been given as ___ argument to operator '___'
+-emacro(835, SLT_F_UNUSED)	// A zero has been given as ___ argument to operator '___'
+-emacro(835, ARGV_COMMENT)	// A zero has been given as ___ argument to operator '___'
+-emacro(835, F_SEEN_ixIX)	// A zero has been given as ___ argument to operator '___'
+-emacro(835, VEX_OPT_CASELESS)	// A zero has been given as ___ argument to operator '___'
+
+///////////////////////////////////////////////////////////////////////
 // <vsb.h>
 
 -esym(759, VSB_*)		// header decl could be moved
diff --git a/lib/libvcc/flint.lnt b/lib/libvcc/flint.lnt
index f0b8f65..50a8868 100644
--- a/lib/libvcc/flint.lnt
+++ b/lib/libvcc/flint.lnt
@@ -29,6 +29,7 @@
 -e716			// while(1) ...
 -e732			// Loss of sign (arg. no. 2) (int to unsigned int)
 
+-emacro(835, EXPR_VAR)	// // Info 835: A zero has been given as right argument to operator '<<'
 
 -e763	// Redundant declaration for symbol '...' previously declared
 



More information about the varnish-commit mailing list